test: fix some compilation issues on win32
Of course, there are still some issue, like sigalarm not being implemented or libtool not being able to launch the test from WSL, but linking failure should be fixed when it compiles.
Merge request reports
Activity
changed milestone to %4.0
added Component::Test label
added MRStatus::Reviewable label
26 26 ssize_t a = (foo); \ 27 27 ssize_t b = (bar); \ 28 28 if(a != b) { \ 29 printf("Failed (%s) line %d : %ld != %ld\n", psz_tag, __LINE__, a, b ); \ 29 printf("Failed (%s) line %d : %zi != %zi\n", psz_tag, __LINE__, a, b ); \ 1 AM_LDFLAGS = $(VLC_ldflags) -no-undefined 2 if HAVE_WIN32 3 AM_LDFLAGS += -mwindows -Wc,-static The
-mwindowsoption marks the EXE as a GUI one according to this doc. I don't think we want that for compat exe.
86 86 LIBVLCCORE = -L../src/ -lvlccore 87 87 LIBVLC = -L../lib -lvlc 88 88 89 if HAVE_WIN32 90 AM_LDFLAGS += -mwindows -Wc,-static The
-mwindowsoption marks the EXE as a GUI one according to this doc. I don't think we want that for test EXE files.
added MRStatus::InReview label and removed MRStatus::Reviewable label
188 193 libvlc_demux_run_la_CPPFLAGS = $(AM_CPPFLAGS) \ 189 194 -DTOP_BUILDDIR=\"$$(cd "$(top_builddir)"; pwd)\" \ 190 195 -DTOP_SRCDIR=\"$$(cd "$(top_srcdir)"; pwd)\" 191 libvlc_demux_run_la_LDFLAGS = -no-install -static I'm more than willing to understand what are those reasons:
-no-install Link an executable output-file that can’t be installed and therefore doesn’t need a wrapper script on systems that allow hardcoding of library paths. Useful if the program is only used in the build tree, e.g., for testing or generating other files.apply to executable files only, and LDFLAGS/LIBADD are not forwarded currently when linking convenience libraries.
-statichas an effect in libtool for convenience libraries, but I'm not sure of the point of doing it here.-statichas an effect in libtool for convenience libraries, but I'm not sure of the point of doing it here.Ok found it:
As a rule of thumb, link a libtool convenience library into at most one libtool library, and never into a program, and link libtool static convenience libraries only into programs, and only if you need to carry library dependency information to the user of the static convenience library.
Without
-static, there is PIC.
added MRStatus::Stale label and removed MRStatus::InReview label
added MRStatus::NotCompliant label and removed MRStatus::Stale label
