Skip to content
Snippets Groups Projects

SettingsCell: Fix crash on iPad

Merged SettingsCell: Fix crash on iPad
diogo.simao-marques/vlc-ios:info-button into master
Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:info-button into master

This merge request fixes a crash issue on iPad when triggering the information button in the Settings View.

UIAlertController with UIModalPresentationPopover as a style need to set up the popoverPresentationController's sourceView & sourceRect.

By doing so, we specify the anchor location for the popover and therefore avoid any crash issue.

This merge request also removes a warning related to a variable that was declared but never mutated.

Alert on iPhone
Alert on iPad

Closes #1495 (closed)

Edited by Diogo Simao Marques

Merge request reports

Merge request pipeline #311299 passed

Stage:
    Stage:

      Merge request pipeline passed for fa638176

      Merged by Felix Paul KühneFelix Paul Kühne 2 years ago (Feb 7, 2023 3:41pm UTC)

      Loading

      Pipeline #311312 passed

      Stage:
        Stage:

          Pipeline passed for fa638176 on master

          Activity

          Filter activity
          • Approvals
          • Assignees & reviewers
          • Comments (from bots)
          • Comments (from users)
          • Commits & branches
          • Edits
          • Labels
          • Lock status
          • Mentions
          • Merge request status
          • Tracking
          • Loading
          • Loading
          Please register or sign in to reply

          VideoLAN code repository instance