Skip to content
Snippets Groups Projects

VLCGoogleDriveTableViewController: Migrate authentication

Merged VLCGoogleDriveTableViewController: Migrate authentication
diogo.simao-marques/vlc-ios:google-drive-auth into master
Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:google-drive-auth into master

What has been done:

  • Migration to a more secure Google Drive authentication way using the GoogleSignIn library.
  • No visual changes to the feature.

What is left to be done:

  • The application needs to be registered into the Google Cloud platform (https://console.cloud.google.com/).
  • Grant the Google Drive API access to the application in order to be able to perform the API calls properly.
  • Retrieve the CLIENT_ID and REVERSED_CLIENT_ID keys replace them into the project.

Closes #1351 (closed)

Edited by Diogo Simao Marques

Merge request reports

Merge request pipeline #262092 passed

Stage:
    Stage:

      Merge request pipeline passed for 1155a2db

      Merged by Felix Paul KühneFelix Paul Kühne 2 years ago (Sep 13, 2022 4:59pm UTC)

      Merge details

      Pipeline #262110 passed

      Stage:
        Stage:

          Pipeline passed for 1155a2db on master

          Activity

          Filter activity
          • Approvals
          • Assignees & reviewers
          • Comments (from bots)
          • Comments (from users)
          • Commits & branches
          • Edits
          • Labels
          • Lock status
          • Mentions
          • Merge request status
          • Tracking
        • Diogo Simao Marques
        • Diogo Simao Marques added 2 commits

          added 2 commits

          • de6269aa - Podfile: Add GoogleSignIn Authentication library
          • e27ef0ff - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Felix Paul Kühne assigned to @fkuehne

          assigned to @fkuehne

        • Felix Paul Kühne
          Felix Paul Kühne @fkuehne ·
          Maintainer

          Please rebase locally so we can merge :smile:

        • Felix Paul Kühne
          Felix Paul Kühne @fkuehne ·
          Maintainer

          NOTA BENE: This needs to be backported to the 3.3 branch until Friday September 23 so we can do a 3.3.9. Google will DISABLE our endpoint on Oct 3 as NO EXCEPTION was granted.

        • Felix Paul Kühne mentioned in merge request !805 (closed)

          mentioned in merge request !805 (closed)

        • Felix Paul Kühne
          Felix Paul Kühne @fkuehne ·
          Maintainer

          See !805 (closed) for the rebase.

        • Diogo Simao Marques resolved all threads

          resolved all threads

        • Diogo Simao Marques added 65 commits

          added 65 commits

          • e27ef0ff...e7a8b193 - 63 commits from branch videolan:master
          • a9349262 - Podfile: Add GoogleSignIn Authentication library
          • 13ae01b7 - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Diogo Simao Marques added 1 commit

          added 1 commit

          • 5e3e5ea3 - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Diogo Simao Marques added 1 commit

          added 1 commit

          • b334bb55 - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Felix Paul Kühne
        • Diogo Simao Marques added 1 commit

          added 1 commit

          • af22b339 - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Diogo Simao Marques added 1 commit

          added 1 commit

          • e9a5fa4b - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Diogo Simao Marques resolved all threads

          resolved all threads

        • Diogo Simao Marques added 3 commits

          added 3 commits

          • 990f2064 - 1 commit from branch videolan:master
          • 34ba2c50 - Podfile: Add GoogleSignIn Authentication library
          • 1155a2db - VLCGoogleDriveTableViewController: Migrate authentication

          Compare with previous version

        • Diogo Simao Marques marked this merge request as ready

          marked this merge request as ready

        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
        • Loading
          • Please register or sign in to reply

          VideoLAN code repository instance