Skip to content
Snippets Groups Projects
  1. Mar 21, 2024
  2. Mar 20, 2024
  3. Mar 19, 2024
    • Darshan Jain's avatar
      qt: CSDWindowButton: import org.videolan.vlc 0.1 library for rendering MainCtx · 296dac62
      Darshan Jain authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      We have to import missing "org.videolan.vlc 0.1" library to access MainCtx
      used in "MainCtx.osName", "MainCtx.Windows", and "MainCtx.Version" to
      get Segoe Font icons according to Windows version.
      
      Earlier, it is generating a qt warning: MainCtx is not defined
      By this commit this gets resolved.
      
      Fixes: #28341
      Related Merge Request: !4984
      296dac62
    • Alexandre Janniaux's avatar
      qt: flickable_scroll_handler: fix uninitialized variables · b5afd73c
      Alexandre Janniaux authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
      setScaleFactor(1.0) was called from the constructor, but then it would
      call qFuzzyCompare() with the current scale factor which was not
      initialized.
      
          ==2600289== Thread 10 vlc-qt:
          ==2600289== Conditional jump or move depends on uninitialised value(s)
          ==2600289==    at 0xE8E56F1: qFuzzyCompare (qglobal.h:904)
          ==2600289==    by 0xE8E56F1: ??? (flickable_scroll_handler.cpp:253)
          ==2600289==    by 0xE8E67EB: ??? (flickable_scroll_handler.cpp:36)
          ==2600289==    by 0xE1F5B76: QQmlElement (qqmlprivate.h:139)
          ==2600289==    by 0xE1F5B76: ??? (qqmlprivate.h:166)
          ==2600289==    by 0x104BE4AA: QQmlType::create(QObject**, void**, unsigned long) const (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x10502AE2: QQmlObjectCreator::createInstance(int, QObject*, bool) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x105030AE: QQmlObjectCreator::create(int, QObject*, QQmlInstantiationInterrupt*, int) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x10502A04: QQmlObjectCreator::createInstance(int, QObject*, bool) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x10503B4C: QQmlObjectCreator::setPropertyBinding(QQmlPropertyData const*, QV4::CompiledData::Binding const*) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x105050BF: QQmlObjectCreator::setupBindings(bool) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x10509185: QQmlObjectCreator::populateInstance(int, QObject*, QObject*, QQmlPropertyData const*) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x105026B5: QQmlObjectCreator::createInstance(int, QObject*, bool) (in /usr/lib/libQt5Qml.so.5.15.12)
          ==2600289==    by 0x105030AE: QQmlObjectCreator::create(int, QObject*, QQmlInstantiationInterrupt*, int) (in /usr/lib/libQt5Qml.so.5.15.12)
      b5afd73c
  4. Mar 18, 2024
  5. Mar 17, 2024
Loading