Skip to content
Snippets Groups Projects
  1. Aug 13, 2024
  2. Aug 12, 2024
    • Advait Dhamorikar's avatar
      avsb: check for empty buffers being passed · 9b737741
      Advait Dhamorikar authored and Steve Lhomme's avatar Steve Lhomme committed
      9b737741
    • Fatih Uzunoğlu's avatar
      qt: make "Media Library" context menu action no longer checkable · b6a90210
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      ... and adjust its title is properly such that:
      
      - If already in player view, the title is "Show main view".
      - If already in main view, the title is "Show player view".
      
      Player view is currently considered another page, therefore
      toggling does not make sense here (also considering the
      navigation history). This button now always pushes into the
      history.
      b6a90210
    • Fatih Uzunoğlu's avatar
      qt: check for QT_QUICK_BACKEND before applying the fallback procedure · 15ba5b52
      Fatih Uzunoğlu authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      `QSG_RHI_BACKEND` determines the RHI backend, but software or OpenVG
      are not part of RHI but rather independent backends.
      
      We should not apply the fallback procedure if `QT_QUICK_BACKEND` is
      specified, which might be `software` or `openvg`.
      15ba5b52
    • Thomas Guillem's avatar
      input_clock: don't check for discontinuites while buffering · f159466c
      Thomas Guillem authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      f159466c
    • Thomas Guillem's avatar
      input_clock: move origin_changed check · 88258ec1
      Thomas Guillem authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      This fix the unlikely case where a backward discontinuity is not
      detected just after the origin is changed.
      88258ec1
    • Thomas Guillem's avatar
      input_clock: rework update arguments · 583a6b8f
      Thomas Guillem authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      Add a b_buffering argument (not to be confused with
      extra_buffering_allowd).
      583a6b8f
    • Thomas Guillem's avatar
      avsb: restart in case of critical failure · 4c13e010
      Thomas Guillem authored and Felix Paul Kühne's avatar Felix Paul Kühne committed
      Seen some crashes with the following error: "AVFoundationErrorDomain
      Code=-11803". It means the OS daemon has crashed.
      
      It could happen on dev branch when starting with screwed timings. But I
      guess it could happen on nominal case too (but very unlikely).
      
      Restart the aout in that case.
      4c13e010
    • Steve Lhomme's avatar
      CI: update debian image with Rust and without Qt5 · 79c1e6ee
      Steve Lhomme authored
      Rust packages include rustc, cargo, cargo-c.
      
      Also without ragel.
      79c1e6ee
    • Ayush Dey's avatar
      input: replace input_item_SetDuration calls with input_SetItemDuration · bf5b6d59
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Fixes #4143
      
      In a `vlc_meta_t` object, each metadata key is associated with a priority:
      VLC_META_PRIORITY_BASIC, VLC_META_PRIORITY_PLAYLIST, or VLC_META_PRIORITY_INBAND.
      During metadata merging, keys with higher or equal priority can override those
      with lower priority. When parsing playlist metadata from a CUE file, keys are now
      assigned a priority of VLC_META_PRIORITY_PLAYLIST. This change prevents subsequent
      audio files, which have VLC_META_PRIORITY_BASIC, from overriding the playlist metadata.
      
      Additionally, this commit ensures that the duration of individual tracks is calculated
      using the 'start-time' and 'stop-time' options. This prevents the total track duration
      from overriding the individual track durations in the playlist.
      bf5b6d59
    • Ayush Dey's avatar
      input: add input_SetItemDuration function · c86e464f
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Add input_SetItemDuration wrapper function to use the 'start-time' and
      'stop-time' values to calculate the track duration.
      Refs #4143
      c86e464f
    • Ayush Dey's avatar
      input: call SetStopStart() for all input threads · 1adfce74
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Move the SetStopStart function to ensure it is called for all input threads, especially
      during preparsing. It ensures that the correct timings are used before the duration of
      the input_item_t is set. Previously, 'start-time' and 'stop-time' values were not parsed
      during preparation, leading to priv->i_start and priv->i_stop defaulting to 0.
      Refs #4143
      1adfce74
    • Ayush Dey's avatar
      input: split StartTitle function into StartTitle and SetStopStart · 015a65ac
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      This commit splits the StartTitle function and introduces the SetStopStart
      function, which is responsible for assigning the 'start-time' and 'stop-time'
      values of the track to the `priv->i_start` and `priv->i_stop` variables.
      Refs #4143
      015a65ac
    • Ayush Dey's avatar
      lua: set metadata priority based on `trusted` property · a4c26155
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Check for value of parsed `trusted` property. If the trusted
      property is true, the metadata priority is elevated to VLC_META_PRIORITY_PLAYLIST.
      If trusted is false, the metadata priority defaults to VLC_META_PRIORITY_BASIC.
      
      Refs #4143
      a4c26155
    • Ayush Dey's avatar
      lua: add trusted metadata property · 192ae78b
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Add function `file_is_playlist` to parse the `trusted` property
      of a file. This function will be used to upgrade the metadata
      priority from `VLC_META_PRIORITY_BASIC` to `VLC_META_PRIORITY_PLAYLIST`
      for files marked as trusted. Set the `trusted` property of CUE files
      as they require playlist metadata priority.
      Refs #4143
      192ae78b
    • Ayush Dey's avatar
      lua: modify TRY_META macro to call vlc_meta_SetWithPriority · fd442e5a
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      In TRY_META macro, replace input_item_Set##b() with vlc_meta_SetWithPriority().
      Rename the TrackNum field to TrackNumber and ArtURL to ArtworkURL for
      consistency with the vlc_meta_type_t enumeration.
      Refs #4143
      fd442e5a
    • Ayush Dey's avatar
      input: add functions to set metadata with priority · 118925e3
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      Rename `vlc_meta_Set` to `vlc_meta_SetWithPriority` and `vlc_meta_SetExtra` to
      `vlc_meta_SetExtraWithPriority`. These functions now accept an additional `priority`
      argument to set the metadata priority for a given key.
      
      Add two macros, `vlc_meta_Set` and `vlc_meta_SetExtra`, which call their respective
      functions with `VLC_META_PRIORITY_BASIC` as the default priority.
      Refs #4143
      118925e3
    • Ayush Dey's avatar
      input: add priority based metadata merging · cb4c8128
      Ayush Dey authored and Steve Lhomme's avatar Steve Lhomme committed
      The vlc_meta_t struct now uses an array of struct vlc_meta_value objects to store
      metadata values along with their associated priorities (VLC_META_PRIORITY_BASIC,
      VLC_META_PRIORITY_PLAYLIST, VLC_META_PRIORITY_INBAND).
      Modified the vlc_meta_Merge function to support priority-based metadata merging.
      Metadata values and extra tags in the destination (dst) are only overwritten by
      source (src) values if the source's priority is greater than or equal to the
      destination's priority.
      Refs #4143
      cb4c8128
  3. Aug 11, 2024
    • Steve Lhomme's avatar
      CI: fix gcc win64 Docker image · c4fa5e31
      Steve Lhomme authored
      docker-images!304 is bogus. It should contain libwine-dev.
      Otherwise we can't build the npapi plugin in nightlies.
      c4fa5e31
    • Sebastian Groß's avatar
      mux: asf: header: set correct number of sub objects · 0f51e327
      Sebastian Groß authored and Steve Lhomme's avatar Steve Lhomme committed
      
      The Microsoft ASF spec states
      
      ```
      Number of Header Objects
      Specifies the number of objects contained within the Header Object, not
      including this one. In addition, the Header Extension Object (sections 3.4
      and 4) is counted as exactly one object regardless of the number of
      subobjects contained within it.
      ```
      
      This means `i_cm_size` should not contribute to the number of sub objects.
      As a result VLC generated ASF files could not be demuxed by gstreamer's
      `asfdemux`.
      
      Fix the number and while at it give some semantic meaning to the magic
      numbers in the code regarding the header sub object.
      
      Though technically we write an unsigned value use int to stay consistent
      with the other size values
      
      Closes #28714
      
      Signed-off-by: default avatarSebastian Gross <sgross@emlix.com>
      0f51e327
    • Ash's avatar
      qt: clean: Removed 'M_names_to_criteria' QHash · 60bcaecb
      Ash authored and Steve Lhomme's avatar Steve Lhomme committed
      The 'M_names_to_criteria' (or 'criterias') QHash as a static data member
      was useful when the 2 member functions
      'nameToCriteria()' and 'criteriaToName()' accessed it.
      Now only 'nameToCriteria()' accesses this QHash.
      So, it's been moved inside the 'nameToCriteria()' method.
      60bcaecb
    • Ash's avatar
      qt: clean: Removed redundant member functions · d2c79f0a
      Ash authored and Steve Lhomme's avatar Steve Lhomme committed
      Removed the redundant 'roleToCriteria()' and 'criteriaToName()'
      member functions from the MLBaseModel and its subclasses.
      d2c79f0a
    • Ash's avatar
      qt: clean: Migrated 'getFirstSymbol()' · 573e3cad
      Ash authored and Steve Lhomme's avatar Steve Lhomme committed
      Migrated the 'getFirstSymbol()' trivial member function
      of the MLBaseModel to mlhelper.
      573e3cad
  4. Aug 10, 2024
Loading