This removes a couple of fixes in the java medialibrary that are causing
issues when displaying network share names until when can find a better
solution.

This reverts commit 82936d22.

This commit creates issues when displaying network share names, and is
reverted, so that we can find a better fix for the original issue #2722

This reverts commit 1cf5481d.

This commit is based on 82936d22 which is being reverted for causing
issues when displaying network share titles

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

Filenames with smb share titles will be null, meaning that title from
libvlc will never be chosen, causing an empty string to be chosen down
the line as title.

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

If storage access isn't granted, the medialibrary init will not add the
internal storage as a medialibrary device. After this, it is only
possible to add external devices. So later discovery of internal storage
will fail, not being registered in the medialibrary database.
To fix this, in the late device addition, a check for internal storage
is added.

Fixes #2689

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

This reverts commit 2338bd92.

This commit causes medialibrary in sdcard to be dropped as it permits
the addition of folders as ML devices, which is not what they are.
This causes the medialibrary remove these "devices" when
updatingDevices, hence removing the selected folders.

Fixes #2791

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

After granting storage permission, if calling activity is an instance
of CustomActionController, it will trigger onStorageAccessGranted
callback. Added implementation to MainTvActivity to trigger ML refresh
on storage permission granting so that the main ui doesn't stay stuck on
the request permission headers.

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

AskStoragePermission checks if the onboarding is done before updating
the ui after giving permission. Though onboarding on tv is based on a
different SharedPreference key KEY_TV_ONBOARDING_DONE instead of
ONBOARDING_DONE_KEY. This checks the correct onboarding key for tv

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

Fixes #2804

Fixes #2833

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

Resume playback snackbar is based on KEY_CURRENT_AUDIO/MEDIA not just
KEY_AUDIO/MEDIA_LAST_PLAYLIST. Clearing history should remove all saved
sharedPreference related to current playback.

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

If libvlc doesn't have any meta for title it will provide the filename.
This can be problematic with m3u8 #EXTINF that provides a title.
This adds a check when updating the title meta. If the libvlc title
provided is equal to the filename then it will proritize the
medialibrary title.

Fixes #2722

Robert Stone authored 2 years ago and Nicolas Pomepuy committed 2 years ago

Fixes #2248

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

On AndroidTV there is no ui to change this setting, by default hidden
files should stay hidden.

Fixes #2802

Duncan McNamara authored 2 years ago and Nicolas Pomepuy committed 2 years ago

This flag is incompatible with startActivityForResult, and causes a
crash when opening the app from a third party app that uses it to open a
video.

Fixes #2797

Fixes #2776

Fixes #2782

Nicolas Pomepuy authored 2 years ago and Duncan McNamara committed 2 years ago

The model was never used and prevented the playback of items
when it was null
Fixes #2770

Fixes #2733