Fixes #320. The problem here is that qidx=0 is (in libaom) a shortcut
for lossless, which normally becomes WHT_WHT, but under some obscure
conditions, it can also be non-lossless, in which case qidx=0 implies
DCT_DCT for luma. For chroma, apparently we should use the default
inference pattern, which becomes DCT_DCT for inter also, but requires
the standard lookup table for intra.

Ronald S. Bultje authored 5 years ago and James Almer committed 5 years ago

This is consistent with libaom's av1_superres_scaled(). Fixes #322.

Fixes C part of #321.

Fixes #318.

After checking if -ldl exists, use it for checking for the dlsym
function.

This fixes building in environments where the dlsym function is
unavailable. (My testcase is NDK builds with -static, where dlsym
isn't available for static linking, only if linking dynamically.)

Henrik Gramner authored 5 years ago and Henrik Gramner committed 5 years ago

Also make the cpuid code a bit more explicit.

The end index given for the top/right edge pixels
was incorrect.

Henrik Gramner authored 5 years ago and Henrik Gramner committed 5 years ago

Doing so is technically undefined behavior even though the pointers
are never dereferenced.

Henrik Gramner authored 5 years ago and Henrik Gramner committed 5 years ago

Memory addresses with certain power-of-two offsets will map to the
same set of cache lines. Using such offsets as strides will cause
excessive cache evictions resulting in more cache misses.

Avoid this by adding a small padding when the stride is a multiple
of 1024 (somewhat arbitrarily chosen as the specific number depends
on the hardware implementation) when allocating picture buffers.

Janne Grunau authored 5 years ago and Henrik Gramner committed 5 years ago

Also prefer clock_gettime over mach_absolute_time on darwin.
clock_gettime is only available in darwin 10.12 and later.

Hopefully fixes #283.

Henrik Gramner authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Only a number that changes on every run is required.

Jan Beich authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

tests/checkasm/checkasm.c:55:5: warning: implicit declaration of function 'gettimeofday' is invalid in C99 [-Wimplicit-function-declaration]
    gettimeofday(&tv, NULL);
    ^

Luc Trudeau authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Applying non-zero offset to a NULL pointer is undefined behavior

Konstantin Pavlov authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

This enables releasing stable versions on the snap store.

Henrik Gramner authored 5 years ago and Henrik Gramner committed 5 years ago

The latter is marked as obsolete by POSIX.

This fixes these warnings with MSVC:
warning C4267: '+=': conversion from 'size_t' to 'int', possible loss of data

Prevents the following compiler warning:

../src/decode.c:1979:32: warning: implicit conversion loses integer precision: 'const ptrdiff_t' (aka 'const long') to 'int' [-Wshorten-64-to-32]
            const int stride = f->cur.stride[!!p];
                      ~~~~~~   ^~~~~~~~~~~~~~~~~~
1 warning generated.

Should fix failures of 'section5' sample on 32-bit systems.

This allows auto-detection between section5 and annexb files, which
share the same extension.

Fixes #304.

Fixes #309.

Luc Trudeau authored 5 years ago and Jean-Baptiste Kempf committed 5 years ago

Enforces software engineering best practices