Skip to content
Snippets Groups Projects

Add unistd.h header for sysconf() on OpenBSD

Closed Brad Smith requested to merge brad/x264:cpu_sysconf_openbsd into master

Merge request reports

Pipeline #186397 passed

Pipeline passed for ba02a9d4 on brad:cpu_sysconf_openbsd

Closed by Brad SmithBrad Smith 3 years ago (Feb 5, 2022 7:23pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • You should fix it for all systems and not only for OpenBSD i.e. it should be like this.

    Also as far I understand <sys/param.h> is not really needed for AltiVec detection on OpenBSD and includes of <sys/sysctl.h> can be unified like this. Can you check this?

  • Author Contributor

    I was only touching the OpenBSD specific path as that's the only OS I deal with and aware of any build issue at the moment, but that first diff does look more appropriate.

    I don't know why sys/param.h is there, but I don't believe it is necessary either. sys/param.h includes sys/types.h so it was probably used with the intention of ultimately including sys/types.h. machine/cpu.h is there for CPU_ALTIVEC. That looks more appropriate.

  • mentioned in issue #45 (closed)

  • I have created alternative MR !97 (merged) with this patches.

  • Author Contributor

    Ok. I will close this.

  • closed

Please register or sign in to reply
Loading