Skip to content
Snippets Groups Projects

Fix memleak when open encoder failed

Open Zhao Zhili requested to merge quink/x264:dev/bugfix into master

Fix #75

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I think this should be enough: CHECKED_PARAM_STRDUP() calls x264_param_strdup() which adds the allocated string pointer to param->opaque, interpreted as a strdup_buffer. So all strings there were allocated (and not literals, for instance) are free'd when you call x264_param_cleanup().

    I've tested this with valgrind, and it seems to solve the leak.

  • Since it's a rather trivial fix, can somebody please merge this? :smile:

Please register or sign in to reply
Loading