Skip to content
Snippets Groups Projects

qml: disable end fade in various list/table views if mini player is visible

Open Fatih Uzunoğlu requested to merge fuzun/vlc:qt/missingfadingedgedisablers into master

I just realized that in many places displayMarginEnd is set, but fading edge disabler is not there (we don't want end fading edge when mini player is visible, because we rely on the frosted glass effect there instead). I also realized DiscoverUrlDisplay.qml does not set displayMarginEnd.

Note that enableEndFade and enableBeginningFade can be force overridden as false if FadingEdge deems fading edge is not feasible or does not make sense, so in most cases it can be left true. However, it obviously is not aware of mini player, so it would not automatically disable fading itself.

Request review @chub.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
Please register or sign in to reply
Loading