Skip to content
Snippets Groups Projects

Apply rotations and flip in a single "if" statement

Closed Mark Harfouche requested to merge hmaarrfk/vlc:4.0_fix_exif_2457 into master

Sorry for the all the noise, and feel free to close without additional discussion.

In looking for the bug in #29101

I originally had trouble compiling from source on the 4.0 branch.

Eventually, i got it working and found that the 4.0 branch (master) actually has this fixed.

However, I do think the code is a bit convoluted.

In my mind:

  1. Read the videos settings
  2. Apply the correct transformations

Doesn't need an extra step of: 3. Now fixup the transformation if they are wrong.

If you do plan on closing this, I can look to backport the existing codepath in the 4.0 branch to !7113 (closed)

On master:

Screenshot_from_2025-03-29_21-31-44

On this branch

Screenshot_from_2025-03-29_21-23-35

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading