Skip to content
Snippets Groups Projects

qml: fix wheeling on playback speed control does not work on Wayland with certain mouse types

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/playbackspeedwaylandwheel into master

By default WheelHandler only accepts mouse (unlike other handlers where all devices are accepted by default), and it also does not make use of synthesized mouse events. We can accept all devices here, I don't see why we should limit the accepted devices here.

Currently on Wayland certain mouse types are not reported as "mouse", this is a problem for the wheel functionality of the playback speed control. Accepting all devices fixes this issue.

Request review @chub.

Merge request reports

Merge request pipeline #584669 passed

Merge request pipeline passed for 95a8efe4

Test coverage 17.96% (0.00%) from 1 job

Merged by Steve LhommeSteve Lhomme 1 month ago (Apr 7, 2025 11:01am UTC)

Loading

Pipeline #584675 passed

Pipeline passed for 95a8efe4 on master

Test coverage 17.92% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading