Skip to content
Snippets Groups Projects

macosx: VLCTimeField: do not use identifier

Merged Marvin Scholz requested to merge ePirat/vlc:epirat-fix-VLCTimeField-crash into master

Overriding setIdentifier is something that should not be done and also that identifier is supposed to be unique so it is not really suitable for our use-case here.

Additionally on older macOS versions this selector is sometimes called with a nil identifier leading to a crash.

Just go back to a dedicated property for this without hooking into the view identifier.

Merge request reports

Merge request pipeline #580756 passed

Merge request pipeline passed for 6434ab75

Test coverage 17.97% (0.00%) from 1 job

Merged by Felix Paul KühneFelix Paul Kühne 1 month ago (Mar 26, 2025 9:43pm UTC)

Loading

Pipeline #580846 passed

Pipeline passed for 6434ab75 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading