Skip to content
Snippets Groups Projects

qt: limit=0 should mean limit=0 in `BaseModel`

Open Fatih Uzunoğlu requested to merge fuzun/vlc:qt/fixlimitzerobehavior into master
  1. Mar 15, 2025
    • Fatih Uzunoğlu's avatar
      qt: make limit=0 behave limit=0 in `BaseModel` · cb7b46c0
      Fatih Uzunoğlu authored
      limit=0 having special value, such as loading
      all items is not intuitive. limit=0 should
      behave as limit is 0, as what it suggests.
      
      Not only that but it also means we need two
      special values to (current case):
      
      - Not load any items. (any negative number?)
      - Load all items. (limit=0)
      
      Where as if limit=0 behaves as limit=0,
      we need only one special value to load all
      items. I propose any arbitrary negative
      number.
      
      The current situation also makes mapping
      more complicated, for example with a view
      that has a property `itemCountToShow`, we
      can not simply map `limit: view.itemCountToShow`,
      because when `itemCountToShow` is 0, this
      would cause the model to load all items.
      cb7b46c0
Loading