Skip to content
Snippets Groups Projects

macosx: Fix crash when going forwards after having gone backwards in browse view

Merged Claudio Cambra requested to merge claucambra/vlc:work/fix-nav-stack into master

When generating new input item node child nodes upon entering a new input node, we deleting the previous instances of the child nodes. This left dangling references in the navigation stack's nav states, leading to crashing when going forwards more than once after having gone backwards using the toolbar buttons

To fix this we now check which stored navigation states are going to be affected by the child node deletion process and provide them with new input node instances which are valid

Signed-off-by: Claudio Cambra developer@claudiocambra.com

Merge request reports

Merge request pipeline #576161 passed

Merge request pipeline passed for d770c075

Test coverage 17.97% (-0.02%) from 1 job

Merged by Steve LhommeSteve Lhomme 1 month ago (Mar 13, 2025 9:26am UTC)

Loading

Pipeline #576165 passed

Pipeline passed for d770c075 on master

Test coverage 17.93% (-0.02%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading