Skip to content
Snippets Groups Projects

qml: optimize `VideoProgressBar` by getting rid of the second rectangle

Merged Fatih Uzunoğlu requested to merge fuzun/vlc:qt/videoprogressbarimprovements into master

It would be also possible to draw the progress bar in the round image directly, but we would still need the explicit progress bar item because shader may not be available and positioning would be more cumbersome that way. Now that we got rid of the clip node and the second rectangle, this should be also fine, at least for the moment.

Request review @chub.

Edited by Fatih Uzunoğlu

Merge request reports

Merge request pipeline #567777 passed

Merge request pipeline passed for d962a908

Test coverage 17.86% from 1 job

Merged by Steve LhommeSteve Lhomme 2 months ago (Feb 18, 2025 6:52am UTC)

Loading

Pipeline #567781 passed

Pipeline passed for d962a908 on master

Test coverage 17.85% from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading