pipewire: don't drain empty streams
Fixes the following assert when seeking more than one time past the end of the file.
src/audio_output/dec.c:1107: vlc_aout_stream_Drain: Assertion `!atomic_load_explicit(&stream->drained, memory_order_relaxed)' failed.
Calling pw_stream_flush(s->stream, true)
, when empty, leads to
undefined behavior and might cause the stream_drained()
callback to be
called in loop (leading to the mentioned assert after a flush).
Edited by Thomas Guillem
Merge request reports
Activity
Filter activity
changed milestone to %4.0
added Component::Audio: Linux plugins label
added MRStatus::NotCompliant label
added MRStatus::Reviewable label and removed MRStatus::NotCompliant label
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
No activity on MR (no thread, no vote) and last update is long enough
-
added 132 commits
-
c8454604...3a325614 - 131 commits from branch
videolan:master
- beecec04 - pipewire: don't drain empty streams
-
c8454604...3a325614 - 131 commits from branch
Please register or sign in to reply