Skip to content
Snippets Groups Projects

pipewire: don't drain empty streams

Merged Thomas Guillem requested to merge tguillem/vlc:pw-drain-flush into master

Fixes the following assert when seeking more than one time past the end of the file.

src/audio_output/dec.c:1107: vlc_aout_stream_Drain: Assertion `!atomic_load_explicit(&stream->drained, memory_order_relaxed)' failed.

Calling pw_stream_flush(s->stream, true), when empty, leads to undefined behavior and might cause the stream_drained() callback to be called in loop (leading to the mentioned assert after a flush).

Edited by Thomas Guillem

Merge request reports

Merge request pipeline #563304 passed

Merge request pipeline passed for beecec04

Test coverage 17.86% (0.04%) from 1 job

Merged by Thomas GuillemThomas Guillem 2 months ago (Feb 6, 2025 7:54am UTC)

Loading

Pipeline #563621 passed

Pipeline passed for beecec04 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading