Skip to content
Snippets Groups Projects

Draft: pause-toggler: fix related event handling issues

Open Khalid Masum requested to merge Labnann/vlc:fix-pause-toggler into master

This commit attempts to some issues caused after merge of !6465 (merged)

  • Fix Doubleclick to toggle fullscreen glitching issue.
  • Fix 360 Video pause-toggling when using click and drag as noted in #28915.
  • Fix a corner case of incorrect mousecallback assignment. This issue was discovered when working with implementation of Interactive MKV at !5925. (Moved this to !6904 (merged))

Also, moved mouse event handling out of EsOutControl for better performance.

TODO:

  • Destroy the timer properly.
  • Maybe use a struct to keep mouse state for pause-toggling.
Edited by Khalid Masum

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #584977 passed

Merge request pipeline passed for 523a6418

Test coverage 18.19% from 1 job
The target branch master does not exist. Please restore it or use a different target branch.
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading