Skip to content
Snippets Groups Projects

qt: preprocess the shaders and support `GL_GOOGLE_include_directive`

Closed Fatih Uzunoğlu requested to merge fuzun/vlc:qt/shaderincludedirective into master

This is by no means a proper preprocessor, but it should be more than enough for our needs.

Request review @chub. Feel free to support invoking QSB with defines, but ideally #include should be supported regardless. Maybe this way is better than invoking QSB with defines directly, because as far as I know, Makefile does not support adding files with parameters.

I also noticed that modifying the shaders does not trigger re-compilation with Makefile. I'm not sure what is wrong there, because the dependency rule is there (%.frag.qsb: %.frag and %.vert.qsb: %.vert). This seems to be already an issue, I'm open to suggestions.

Merge request reports

Merge request pipeline #552099 passed

Merge request pipeline passed for cd6bc1e2

Test coverage 17.72% from 1 job

Closed by Fatih UzunoğluFatih Uzunoğlu 3 months ago (Feb 4, 2025 3:31pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading