Skip to content
Snippets Groups Projects

breakpad: remove MAX_PATH limits

Merged Steve Lhomme requested to merge robUx4/vlc:breakpad-pathes into master
All threads resolved!

It's unlikely the user path is that large, but just in case we are ready.

This fixes an issue where the result of _snwprintf() is not checked. The wstringstream will only fail if there's no memory. At this point further calls using std::map and breakpad will also fail.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marvin Scholz resolved all threads

    resolved all threads

  • Steve Lhomme added 1 commit

    added 1 commit

    • a40b083b - breakpad: remove MAX_PATH limits

    Compare with previous version

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • Steve Lhomme added 37 commits

    added 37 commits

    Compare with previous version

  • Steve Lhomme enabled an automatic merge when all merge checks for 05e7dae2 pass

    enabled an automatic merge when all merge checks for 05e7dae2 pass

  • merged

  • Please register or sign in to reply
    Loading