[3.0] fetcher: don't download network metadata if the user doesn't want to

The option is defined as "Allow metadata network access". If it's false (default but query during the first run) that means the user doesn't want to check metadata from the network. So we should not start a network job when there's a possibility to do it.

This is a regression from ea88b8d6. Before that we only used FETCHER_SCOPE_LOCAL if the option wasn't set.

(cherry picked from commit 1a85d679)

Draft until !6170 (merged) merged in master.

The 3.0 code is more tricky so we just keep checking at the last minute we may want to access the network.

changed milestone to %3.0.x maintenance

added Component:: Metadata label

changed the description

approved this merge request

added 1 commit

• 09d8be7b - fetcher: don't download network metadata if the user doesn't want to

Compare with previous version

marked this merge request as ready

changed the description

added MRStatus::Acceptable label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, and score >= 0
• MergeRequest should have no activity (threads/votes) for (24h/24h)

This message was automatically generated by homer-bot.

added 18 commits

• 09d8be7b...a618e31c - 17 commits from branch videolan:3.0.x
• 5cdb9b25 - fetcher: don't download network metadata if the user doesn't want to

Compare with previous version

enabled an automatic merge when the pipeline for 5cdb9b25 succeeds

merged