Skip to content

[3.0] contribs/module: update taglib to 1.13.1

Steve Lhomme requested to merge robUx4/vlc:taglib-1131 into 3.0.x

We still support taglib 1.9 unlike VLC 4 which needs at least taglib 1.11.

That will avoid libvlcjni to add the patches that were added in VLC 4. And therefore allow libvlcjni to use the prebuilt 3.0 contribs built here. Although it went a little further and required taglib 1.11.

All patches are direct cherry-picks from the master branch, with only rebase changes due to surrounding code.

After this MR the differences of taglib.cpp between 3.0 and 4.0 are:

  • optional 1.11 support using a define, including using the old FileRef constructor on older APIs
  • not using the C++ vlc::threads helpers
  • using set_callbacks() instead of set_callback()
  • calling vlc_meta_AddExtra() instead of vlc_meta_SetExtra()
Edited by Steve Lhomme

Merge request reports