[3.0] contribs/module: update taglib to 1.13.1
We still support taglib 1.9 unlike VLC 4 which needs at least taglib 1.11.
That will avoid libvlcjni to add the patches that were added in VLC 4. And therefore allow libvlcjni to use the prebuilt 3.0 contribs built here. Although it went a little further and required taglib 1.11.
All patches are direct cherry-picks from the master branch, with only rebase changes due to surrounding code.
After this MR the differences of taglib.cpp between 3.0 and 4.0 are:
- optional 1.11 support using a define, including using the old FileRef constructor on older APIs
- not using the C++ vlc::threads helpers
- using
set_callbacks()
instead ofset_callback()
- calling
vlc_meta_AddExtra()
instead ofvlc_meta_SetExtra()
Merge request reports
Activity
changed milestone to %4.0
added Component:: Metadata Component::Build system: Contribs labels
added MRStatus::NotCompliant label
added 31 commits
- 38671f45...d19aec68 - 21 earlier commits
- eba02d70 - taglib: Reduce FileRef scope
- 15e5e785 - taglib: Use nullptr instead of 0 for pointers
- 76867ceb - taglib: Fix invalid version check
- 08eb0169 - meta: taglib: use std::min
- d9d91e78 - taglib: don't cast the file st_size to a possibly smaller type
- 0eecc89c - contrib: taglib: Update patch from upstream
- de0de07c - contrib: taglib: update to 1.13
- 0806032f - taglib: remove VLC path define check
- dc117cc7 - contrib: Bump taglib to 1.13.1
- b44026fb - Taglib: Use ID3v2Tag() instead of tag() for RIFF::WAV::File
Toggle commit listadded MRStatus::Reviewable label and removed MRStatus::NotCompliant label
added 31 commits
- b44026fb...4fba11a8 - 21 earlier commits
- 22ce9c79 - taglib: don't cast the file st_size to a possibly smaller type
- 8efa4144 - contrib: taglib: Update patch from upstream
- bb801363 - contrib: taglib: update to 1.13
- d1b3f971 - taglib: remove VLC path define check
- f7665df1 - contrib: Bump taglib to 1.13.1
- 8ab6683c - Taglib: Use ID3v2Tag() instead of tag() for RIFF::WAV::File
- b8ccadb6 - contrib: Bump taglib to 2.0
- 6e2542b2 - contrib: taglib: use github source for tarballs
- 361c72f6 - contrib: taglib: get utfcpp as a release tarball
- 9e5f5180 - contrib: taglib: bump to 2.0.1
Toggle commit listchanged milestone to %3.0.x maintenance
added MRStatus::Accepted label and removed MRStatus::Reviewable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
No activity on MR (no thread, no vote) and last update is long enough
-
added 33 commits
-
8ab6683c...1f265fe0 - 3 commits from branch
videolan:3.0.x
- 1f265fe0...d226e0c6 - 20 earlier commits
- 6a14f299 - taglib: Implement new StreamTypeResolver interface when available
- ba858385 - taglib: Use nullptr instead of 0 for pointers
- 01c9003d - taglib: Fix invalid version check
- 286d843d - meta: taglib: use std::min
- 651da62c - taglib: don't cast the file st_size to a possibly smaller type
- 97f309a7 - contrib: taglib: Update patch from upstream
- 78af081d - contrib: taglib: update to 1.13
- 6da0cba6 - taglib: remove VLC path define check
- e69ef263 - contrib: Bump taglib to 1.13.1
- 5ee481af - Taglib: Use ID3v2Tag() instead of tag() for RIFF::WAV::File
Toggle commit list-
8ab6683c...1f265fe0 - 3 commits from branch
enabled an automatic merge when the pipeline for 5ee481af succeeds
added MRStatus::NotCompliant label and removed MRStatus::Accepted label
added MRStatus::Accepted label and removed MRStatus::NotCompliant label