Skip to content
Snippets Groups Projects

contrib: qtdeclarative: do not provide qtdeclarative-tools

Closed Fatih Uzunoğlu requested to merge fuzun/vlc:qt/contribqtdeclarativetools into master

We currently use qmlcachegen, but we don't need to necessarily provide that tool because Qt saves the cached QML types into files at first start-up* anyway.

We do not need to care too much about the performance of the first start-up. And, this patch does not remove the functionality of using the qmlcachegen tool. The said tool can still be used when it is present.

It should be also noted that it is beneficial to have qmlcachegen in a development setup, because it tells if a QML file contains some errors. After this patch, the CI is still going to use the tool in other builds.

This enables reverting 185d3fba, which in turn enables us to update patch version of Qt without updating the images used by the CI that contain the tools. Exact version dependency of the tools are in fact only valid for qmlcachegen. Rest of the tools only demand equal or greater Qt version, and do not care if patch version is different.

  • In fact, the very first loading of the type.

Request review @robUx4 @chub.

Merge request reports

Merge request pipeline #562312 passed

Merge request pipeline passed for fdf3fa62

Test coverage 17.73% from 1 job
Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading