macosx: fix continous playback store cutoff

This problem took me a while to track down. I noticed that sometimes the continuous playback feature just didn't work.

Background: I sometimes lose track of which is the last episode in a season that I had watched. So, in order to find out, I restart a candidate episode and expect it to continue near the end if I watched it to near the end before. Sometimes this worked, and sometimes it didn't, meaning even though I had watched the episode, it would restart at the beginning.

The reason is that, on MacOS, the continue time is only stored if you watch less than 95% of the video. So, depending on the overall length, you get different behavior, and overall it doesn't really "feel" continuous for some use-cases. I strongly recommend increasing this max store percent to 99.

added 6 commits

• 66c7c25a...b2406ca9 - 5 commits from branch videolan:master
• 94ddbf76 - increase max store percent to 99

Compare with previous version

changed the description

Thanks

Thanks for your contribution!

When all of the following conditions are fulfilled, your MergeRequest will be reviewed by the Team:

• the check pipeline passes
• the MR is considered as 'mergeable' by gitlab

You can find more details about the acceptance process here.

This message was automatically generated by homer-bot.

added MRStatus::Reviewable label

changed milestone to %4.0

added Component::Interface: macOS Platform::macOS labels

This seems ok to me. Another option would be to adopt the same more refined behavior deployed on Android and iOS. /cc @dfuhrmann @ePirat

@ePirat @dfuhrmann do you have opinions?

I am not a fan of this change: We need to avoid that it just resumes 2-3 seconds before the end, so you start the video and it "immediately" finishes. So in other words, this also needs to work for short video samples.

We could define different rules per video length, but it makes the problem only more complex. Or we implement something more intelligent for VLC 4 which should properly mark a video as played in the ML.

What you kinda want I guess is some kind of outro detection, and this is hard to archieve. In the end, the current mechanism is no replacement for marking videos as already watched - and you can also always watch a video to the very end.

@dfuhrmann Did you read the problem I outlined with the current approach? As a user, I feel you would not not need to avoid that the video resumes at the end (even for 2--3 seconds), if I had watched to that point. In fact that was the behavior I was naturally expecting.

I did not ask for different behavior for different video lengths. I did not ask for outro detection. If the video was marked as fully watched, when it was fully watched, then imo that would not help with the problem I outlined.

After a full month, I honestly don't expect this change to be merged. So, feel free to close.

Well, I certainly read your message, and as you can see here, they can be always different opinions.

For me it would feel weird that the continue playback feature directly jumps to the very end, and basically does not play anything anymore. If you want to archieve this, you could also have set 100%.

But other people can give other opinions.

approved this merge request

added MRStatus::InReview label and removed MRStatus::Reviewable label

added 419 commits

• 94ddbf76...9dd68a3c - 418 commits from branch videolan:master
• bf043ad6 - increase max store percent to 99

Compare with previous version

closed