glx: bind/restore GLX ctx before/after buffer swap
These changes seek to fix an issue in which the GLX video output renders only black with some drivers, such as with a software renderer (e.g., LIBGL_ALWAYS_SOFTWARE=true
and GALLIUM_DRIVER=llvmpipe
). Bisection found that this issue existed since commit 9b7514f9.
The proposed changes fix the issue by binding the GLX video output's context before calling glXSwapBuffers()
and then restoring the previous context afterwards. Something similar is already done by the EGL video output on buffer swaps.
Merge request reports
Activity
added MRStatus::Reviewable label
changed milestone to %4.0
added Component::Video: OpenGL label
assigned to @alexandre-janniaux
- Resolved by Alexandre Janniaux
Hi, can you do the same as !1973 (merged) and have the merge request cover letter inside the commit message as well ?
added MRStatus::InReview label and removed MRStatus::Reviewable label
added 1 commit
- f40c2795 - glx: bind/restore GLX ctx before/after buffer swap
added MRStatus::NotCompliant label and removed MRStatus::InReview label
mentioned in merge request !4736
added MRStatus::InReview label and removed MRStatus::NotCompliant label
unassigned @alexandre-janniaux
added MRStatus::Stale label and removed MRStatus::InReview label