Skip to content
Snippets Groups Projects

qml: remove bad model aliases

Open Fatih Uzunoğlu requested to merge fuzun/vlc:qt/aliasfixes into master

It does not seem possible to make model read-only, so the best would be to not use aliases here. If we can not make model property read-only, this leads to a dangerous situation of the model being changed accidentally or for other reasons which would be very hard to debug.

If we overload the model as read-only, base class still does not use the override. Since there is ListSelectionModel in the base class, it will continue to be bound to the old model instead of the new set one.

Edited by Fatih Uzunoğlu

Merge request reports

Members who can merge are allowed to add commits.

Merge request pipeline #413224 passed

Merge request pipeline passed for 8bb0826d

Merge request contains no changes

Use merge requests to propose changes to your project and discuss them with your team. To make changes, use the Code dropdown list above, then test them with CI/CD before merging.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading