Skip to content
Snippets Groups Projects

memstream: fix some bogus assumptions and add helper to destroy

Closed Steve Lhomme requested to merge robUx4/vlc:stream_close_success into master

The forcing of NULL on error is useful. Not checking the error on close is useful for readability, but it generates warnings because of VLC_USED. And not using VLC_USED might lead for forgetting checking the error. So I might drop these patches. And since vlc_memstream_close() returns an allocated pointer, we may want to use VLC_MALLOC.

Edited by Steve Lhomme

Merge request reports

Merge request pipeline #409365 passed

Merge request pipeline passed for 0d7c98b2

Closed by Steve LhommeSteve Lhomme 1 year ago (Nov 24, 2023 1:05pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading