Skip to content

medialibrary: MetadataExtractor: fix ignored-attributes

Alexandre Janniaux requested to merge alexandre-janniaux/vlc:medialibrary-metadata/1 into master

The function fclose is tagged as __nonnull((1)) and GCC will warn that the attribute will be ignored. Fix the following warning:

../../modules/misc/medialibrary/MetadataExtractor.cpp: In member function ‘virtual bool EmbeddedThumbnail::save(const std::string&)’:
../../modules/misc/medialibrary/MetadataExtractor.cpp:44:44: warning: ignoring attributes on template argument ‘int (*)(FILE*)’ [-Wignored-attributes]
   44 |     std::unique_ptr<FILE, decltype(&fclose)> f{ vlc_fopen( path.c_str(), "wb" ),
      |                                            ^

Merge request reports

VideoLAN code repository instance