Simple preferences: Don't bind the preference to enqueue files to the one-instance mode preference

Technically the enqueue preference could be disabled if both one-instance mode and one-instance mode from the file manager are unchecked. But that would require a custom slot to check the state of both checkboxes whenever either of them is toggled, and it seems easier to just remove the connection between the two preferences.

The labeling for the enqueue preference, at least in English, is "Enqueue items into playlist in one instance mode", which IMHO makes it pretty clear that if neither one-instance preference is checked, it won't do anything even if it's enabled.

I think indeed that the option should be disabled when both "one-instance" mode are disabled, something like this should work if you don't want to create a custom slot

                auto onOneInstanceChanged = [ui]() {
                    bool enabled = ui.OneInterfaceMode->isChecked() || ui.oneInstanceFromFile->isChecked();
                    ui.EnqueueOneInterfaceMode->setEnabled(enabled);
                };
                onOneInstanceChanged();
                connect( ui.OneInterfaceMode, &QCheckBox::toggled, this, onOneInstanceChanged );
                connect( ui.oneInstanceFromFile, &QCheckBox::toggled, this, onOneInstanceChanged );

note that copying the ui for the lambda is not ideal, we should rather keep the individual ui objects of each pages in our object

I tend to agree with @Courmisch regarding the use of the dropdown for the single instance mode, but this may be the subject of a different MR

note that copying the ui for the lambda is not ideal, we should rather keep the individual ui objects of each pages in our object

I proposed this here !3882 (merged)

mentioned in merge request !3831 (closed)

changed milestone to %4.0

added Component::Interface: Qt label

added Status::BackportCandidate label

added MRStatus::Reviewable label

added 13 commits

5b4d89c2...82f19b9f - 12 commits from branch videolan:master
2e05683a - Don't bind enqueue pref to one-instance mode

Compare with previous version

requested review from @jbk

added 25 commits

2e05683a...5df262a4 - 24 commits from branch videolan:master
ae4e1fc8 - Don't bind enqueue pref to one-instance mode

Compare with previous version

resolved all threads

cc @chub is that OK with you ?

There are three flags for 8 total combinations but only 6 possible behaviours.

I agree that playlist-enqueue should be independent. But at the same time, the existing code does have a point that not all 8 combinations make sense.

Single instance mode should be reduced to three possibilities: always, with file, and never. This can be achieved with a 3-entry option box, a drop-down list or by hiding the with-file option when single instance is enabled. I'm no UX expert to tell what's right on that point.

Note that we can't change the underlying flags as that would wreck havoc over the CLI.