Skip to content
Snippets Groups Projects

taglib: wav: parse additional RIFF INFO tags

Merged Alaric Senat requested to merge asenat/vlc:taglib-parse-wav-info into master

TagLib does not provide an union of both ID3v2 and INFO tags via the usual File::tag() method. Their justification lies in the code for now:

/*!
 * Returns the ID3v2 Tag for this file.
 *
 * \note This method does not return all the tags for this file for
 * backward compatibility.  Will be fixed in TagLib 2.0.
 */
ID3v2::Tag *tag() const;

To support WAV files providing RIFF INFO tags, we must specifically parse them before TagLib 2.0 (not released yet).

Fixes #25690 (closed)

Merge request reports

Merge request pipeline #323513 passed

Merge request pipeline passed for a26e2ba3

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 1 commit will be added to master.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for this.

  • Jean-Baptiste Kempf approved this merge request

    approved this merge request

  • Alaric Senat added 1 commit

    added 1 commit

    • ab77247a - taglib: wav: fix RIFF INFO tags parsing

    Compare with previous version

  • Alaric Senat resolved all threads

    resolved all threads

  • @asenat please BP afterwards.

  • François Cartegnie
  • François Cartegnie resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading