macosx: Remove use of static control bar in video views, always use fspanel instead
At the moment we have a static control bar that displays during video playback when the player window is windowed or in macOS' native full screen mode.
IMO there are several reasons to replace this entirely with the hovering panel we display in the normal full screen mode:
- It is more space efficient and features the same functionality, improving the UX when using a smaller window
- It looks more akin to native video playback control panels in macOS
- Most importantly, it allows us to move towards a potential removal of the non-native fullscreen mode in the video player, significantly simplifying our video window code as we will have fewer situations where we need to intircately handle the consequences of being in windowed/full-screen/native full-screen
For context, this is what it looks like with the changes in this PR + cherry-picked changes from !2945 (merged)
windowed:
Screen_Recording_2022-12-09_at_01.52.50
native full-screen:
Screen_Recording_2022-12-09_at_01.54.50
Signed-off-by: Claudio Cambra developer@claudiocambra.com
Merge request reports
Activity
added MRStatus::Reviewable label
-
Okay, could you elaborate? Are there any changes that can be made here to improve the use of the fspanel? If not, what should we do in full-screen?
For context, this is what we have in master, creating a really weird distinction between native full-screen and overlay full-screen:
Screen_Recording_2022-12-09_at_12.25.33
From my POV I don't see what benefits this big control bar brings to the video view since it doesn't bring any additional functionality, at the cost of taking up a lot of space and requiring this distinction between native full-screen and overlay full-screen
Better solutions are welcome ofc
Edited by Claudio Cambra
added Component::Interface: macOS Platform::macOS labels
changed milestone to %4.0
added MRStatus::InReview label and removed MRStatus::Reviewable label
added MRStatus::NotCompliant label and removed MRStatus::InReview label
added 229 commits
-
d1245640...242eeb56 - 223 commits from branch
videolan:master - d6114aae - macosx: Remove control bar from detached video window
- 8fb28b27 - macosx: Eliminate use of control bar as playback controls in video windows,...
- 86ae826e - macosx: Fully eliminate static control bar from main library window when playing video
- dce2c10a - macosx: Remove config option to disable fspanel as this is now our only video controls
- aa37d76c - macosx: Fix issues with fspanel suddenly disappearing on initial invoking of video view
- aec6c305 - macosx: Clean up public API of VLCFSPanelController
Toggle commit list-
d1245640...242eeb56 - 223 commits from branch
added 1 commit
- a709b387 - macosx: Use correct notification name for controller being shown in VLCLibraryWindow
added MRStatus::InReview label and removed MRStatus::NotCompliant label
added MRStatus::NotCompliant label and removed MRStatus::InReview label
