Skip to content

macosx: Remove use of static control bar in video views, always use fspanel instead

At the moment we have a static control bar that displays during video playback when the player window is windowed or in macOS' native full screen mode.

IMO there are several reasons to replace this entirely with the hovering panel we display in the normal full screen mode:

  • It is more space efficient and features the same functionality, improving the UX when using a smaller window
  • It looks more akin to native video playback control panels in macOS
  • Most importantly, it allows us to move towards a potential removal of the non-native fullscreen mode in the video player, significantly simplifying our video window code as we will have fewer situations where we need to intircately handle the consequences of being in windowed/full-screen/native full-screen

For context, this is what it looks like with the changes in this PR + cherry-picked changes from !2945 (merged)

windowed:

Screen_Recording_2022-12-09_at_01.52.50

native full-screen:

Screen_Recording_2022-12-09_at_01.54.50

Signed-off-by: Claudio Cambra developer@claudiocambra.com

Merge request reports

Loading