RFC: videotoolbox: ignore null imageBuffer and continue (!1790) · Merge requests · VideoLAN / VLC

Zhao Zhili requested to merge quink/vlc:videotoolbox-dev into master Apr 15, 2022

I have got a video which has a few frames corrupted. Videotoolbox DecoderCallback doesn't indict error via OSStatus but with null CVPixelBufferRef. After a few frames, it can continue with no problem. So it's not a critical error in this case.

The following commit message shows that such case has happened before, but I don't know if it can recover in that case or not.

commit 89b96cdadfea8d8ed3095238f811dc5865950052
Author: Thomas Guillem <thomas@gllm.fr>
Date:   Fri Mar 2 17:16:57 2018 +0100

    videotoolbox: remove imageBuffer assert

    Since this case can finally happen.

@tguillem

Ping me if you need the sample file.

RFC: videotoolbox: ignore null imageBuffer and continue

Merge request reports