Steve Lhomme authored 6 years ago and Hugo Beauzée-Luyssen committed 6 years ago

Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

cf. videolan/vlc-ios#261



A lot of crashes happen when doing the CVPX HW -> SW conversion. Unfortunately,
I was unable to reproduce it.

My best guess is that this buffer overflow is caused by the i_visible_height
that is too big.  This value should be correct since it comes from the hxxx
packetizer, but it may be different from the actual height of the cvpx buffer.

(cherry picked from commit d0de1ecd)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

(cherry picked from commit 0fd8cdab)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit d88ee7f0)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

The old code does not take into account the index shifts if
dragging an item down the list.
Easy fix is to reload the whole model for now.

(cherry picked from commit 7cb147a3)
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>

QTKit header includes objc header files, therefore the configure
check must be done with an objc file. Also, fix build of qtsound
module.

(cherry picked from commit 0d181b41)
Signed-off-by: David Fuhrmann <dfuhrmann@videolan.org>

Olivier Fourdan authored 6 years ago and Hugo Beauzée-Luyssen committed 6 years ago

commit 58155349 ("qt: make the time tooltip a tooltip") reintroduced the
bug fixed by previous commit ea992379 ("remove X11BypassWindowManagerHint
from time tooltip") meant to fix #17829.

The tooltip window is a shaped, override-redirect window which shows
when the pointer enters the slider and disappears when it leaves the
slider.

By placing the tooltip window too low, above the slider, vlc causes a
constant map/unmap of that window which will flood Xwayland and the
Wayland compositori.window manager and can up with a deadlock situation.

When the tooltip window is showing, the pointer will enter the tooltip
window and thus leave the slider, which will cause the tooltip to be
unmapped, which in turn causes the pointer to re-enter the slider area,
which will cause the tooltip to show again, so on and so forth.

On Wayland/Xwayland where the Wayland compositor (i.e. the display
server) is also the window manager, that can lead to a deadlock
situation because some X11 requests are blocking on rountrips to the
Xserver, which in the case of Xwayland is also a Wayland client, waiting
on the Wayland compositor for some operations, the Wayland compositor
being also a Window manager and an X11 client at the same time...

Avoid the issue by placing the tooltip so that it does not show up at
the same location where the slider is, without overlap, to avoid that
map/unmap requests storm.

Closes: https://gitlab.gnome.org/GNOME/mutter/issues/244


Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>
(cherry picked from commit 6579a36c)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

(cherry picked from commit cedb5bb7)

(cherry picked from commit 2b111c4b)

(cherry picked from commit fa4d9d65)

Zhao Zhili authored 6 years ago and Thomas Guillem committed 6 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
(cherry picked from commit 2142b90d7ecb2d38bb7e11db36344d3d8ed80335)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Zhao Zhili authored 6 years ago and Thomas Guillem committed 6 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>
(cherry picked from commit 0cdd6619555ddbee99f1097ecfbaefe22c7dafab)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

hopefully the location won't change in future Windows versions

(cherry picked from commit 28676840)

Some formats are not handled properly by drivers and so we should fallback
to working ones when looking for a display format.

Ref #19162
Ref #20681 (work around the conversion issue which I can't reproduce)

(cherry picked from commit ef69fb83)

So we can test for more errors and log them.

(cherry picked from commit 58739768)

refs broken_RV24_as_Compression.avi.bz2

(cherry picked from commit 484ac1b7)

(cherry picked from commit 46139983)

Close #20580

(cherry picked from commit 23e8aa02)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

ssbssa authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz>
(cherry picked from commit b9cef2cc)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Ref: #20343
(cherry picked from commit 923dcb3c)

(cherry picked from commit 44bbb10a)

(cherry picked from commit 83d8394d)

(cherry picked from commit 6f6803c9)

hopefully the location won't change in future Windows versions

(cherry picked from commit 81e6e779)

(cherry picked from commit 2c2eeb8e)

(cherry picked from commit 0d6753dc)

The VersionHelpers API is available since Win2000

(cherry picked from commit c0abd168)

Ref #20343

(cherry picked from commit d170d0d7)

(cherry picked from commit 65eed1b9)

Not used for now.

(cherry picked from commit 33cc4f2b)

(cherry picked from commit 6dd231f7)

(cherry picked from commit 79c56aad)

(cherry picked from commit 9daba7a1)

(cherry picked from commit ec1313ce)