Skip to content
Snippets Groups Projects

NetworkCells: Fix network cells height attribution

Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:network-cell into master
All threads resolved!

This merge request brings a fix to the network cells' height attribution:

  • The network cells' height are not hardcoded values anymore.
  • The labels sizes are now considered while computing the cells' height.

This merge request also introduces a delegation to update the table view.

The remote network table view is now updated when the WiFi cell's switch is toggled, allowing the table view to display properly the details of the WiFi cell, which content is updated after this interaction.

The following screen shots show an overview of the cells with different font sizes selected in the accessibility settings.

Screenshots on iPhone
Screenshots on iPad
Screen recodings of the WiFi cell's update behavior Network_cells_-_Update

Network_cells_Update_2

Closes #1395 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • added 4 commits

    • ab25f761...255bff12 - 2 commits from branch videolan:master
    • 58498101 - NetworkCells: Fix network cells height attribution
    • 018ebcf3 - VLCWiFiUploadTableViewCell: Add delegation to update the table view

    Compare with previous version

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading