Skip to content
Snippets Groups Projects

Accessibility: Fix Voice Over scope & add missing accessibility labels

Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:accessibility into master
All threads resolved!

This merge request brings fixes to:

The Voice Over scope in the action sheet: the .isAccessibilityElement set to true in the background view was preventing Voice Over to access its subviews.

Therefore, when Voice Over was enabled, it was not able to read the accesibility labels of the subviews and nothing was read.

This merge request also adds:

Missing accessibility labels to:

  • The action sheet
  • The options navigation bar
  • The playback speed view

Closes #1387 (closed)

Merge request reports

Merge request pipeline #268925 passed

Merge request pipeline passed for 31e9efbc

Approved by

Merged by Felix Paul KühneFelix Paul Kühne 2 years ago (Oct 4, 2022 5:57pm UTC)

Merge details

Pipeline #269387 passed

Pipeline passed for 31e9efbc on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 7 commits

    • 9dac7000...a3c2544f - 5 commits from branch videolan:master
    • 95d536ed - ActionSheet: Enable Voice Over to read subviews labels
    • d9f0a2a1 - Accessibility: Add missing accessibility labels

    Compare with previous version

  • added 1 commit

    • 31e9efbc - Accessibility: Add missing accessibility labels

    Compare with previous version

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Diogo Simao Marques mentioned in merge request !856 (merged)

    mentioned in merge request !856 (merged)

  • mentioned in issue #1343 (closed)

  • Please register or sign in to reply
    Loading