Skip to content

SMB: Enables share path

tanenyi requested to merge tanenyi/vlc-ios:SMB-share into master

Correctly parses address into host and path.

Existing

graph TB
  input-->login.host
  login.URL -->output
  subgraph "Input"
  input(["#quot;/Share/PathName#quot;"])
  end
  subgraph "SMBNetworkServerBrowserWithLogin"
  object[VLCNetworkServerLoginInformation login]-->login.host-->login.URL-->LOGIN
  end
  subgraph "Output"
  output(["#quot;Share%2fPathName#quot;"])
  end

Result: FAIL

With Update

graph TB
  share-->login.host
  pathName-->login.path
  login.URL -->output
  subgraph "Input"
  input(["#quot;/Share/PathName#quot;"])-->share(["#quot;Share#quot;"]) & pathName(["#quot;/PathName#quot;"])
  end
  subgraph "SMBNetworkServerBrowserWithLogin"
  object[VLCNetworkServerLoginInformation login]-->login.host & login.path-->login.URL-->LOGIN
  end
  subgraph "Output"
  output(["#quot;Share/PathName#quot;"])
  end

Result: PASS

(closes https://trac.videolan.org/vlc/ticket/22938)

Merge request reports

Loading