Skip to content
Snippets Groups Projects

VideoPlayerViewController: Fix the aspect ratio regression

Merged Diogo Simao Marques requested to merge diogo.simao-marques/vlc-ios:aspect-ratio into master

This merge request brings a fix to the aspect ratio regression with:

  • The delegate's optional method that is now properly declared to allow the Playback Service to call it when needed.
  • The delegate's optional method allowing to adjust the video output view according to the aspect ratio selected that is now properly called after the application of the aspect ratio.

This fixes also the aspect ratio application through the action sheet selection.

Screen Recordings Aspect_Ratio_-_Button Aspect_Ratio_-_Action_Sheet

Closes #1788 (closed)

Merge request reports

Merge request pipeline #439943 passed

Merge request pipeline passed for 8f6a8255

Approved by

Merged by Felix Paul KühneFelix Paul Kühne 1 year ago (Feb 20, 2024 1:59pm UTC)

Merge details

Pipeline #439960 passed

Pipeline passed for 8f6a8255 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading