Skip to content
Snippets Groups Projects

playback speed controls on Audio Player

Merged Rizky Maulana requested to merge Perklone/vlc-ios:playbackspeed-player into master
All threads resolved!

This features adds a playback speed button so the user can change their playback speed button without having to take the extra steps of going to the moreOptions and into the playbackSpeedView settings.

Currently, there's an issue with implementing the action sheet when the user long presses the playback speed button to access the playbackSpeedView.

Demo: Simulator_Screen_Recording_-iPhone_14-_2023-08-17_at_22.30.47

Closes #1683 (closed)

Merge request reports

Merge request pipeline #382278 passed

Merge request pipeline passed for c0139f4d

Approval is optional
Ready to merge by members who can write to the target branch.

Merge details

  • 1 commit will be added to master.
  • Source branch will be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Diogo Simao Marques changed milestone to %3.5.0

    changed milestone to %3.5.0

  • Rizky Maulana added 1 commit

    added 1 commit

    • 5f9a8d39 - AudioPlayerViewController: Added Long Press feature for playback button

    Compare with previous version

  • Rizky Maulana resolved all threads

    resolved all threads

  • Rizky Maulana added 1 commit

    added 1 commit

    • d2b393b3 - AudioPlayerViewController: Added Long Press feature for playback button

    Compare with previous version

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Felix Paul Kühne resolved all threads

    resolved all threads

  • Felix Paul Kühne added 73 commits

    added 73 commits

    • d2b393b3...a6c3b543 - 71 commits from branch videolan:master
    • 995c9c34 - AudioPlayerView: Added PlaybackSpeed Button
    • c0139f4d - AudioPlayerViewController: Added Long Press feature for playback button

    Compare with previous version

  • Felix Paul Kühne marked this merge request as ready

    marked this merge request as ready

  • Felix Paul Kühne enabled an automatic merge when the pipeline for c0139f4d succeeds

    enabled an automatic merge when the pipeline for c0139f4d succeeds

  • Please register or sign in to reply
    Loading