Search While Delete: Pass searchDataSource to EditController in initialization.

Still a work in progress because of a lot of UI glitches. Fixes #675 (closed)

A screen recording of it in action:

Changes:

1. new computed variable "currentDataSet" in both MediaCategoryViewController and EditController that returns either searchDataSource.searchData or model.anyfiles
2. searchDataSource reference from MediaCategoryViewController is passed to EditController
3. isSearching bool now in LibrarySearchDataSource so that both view controllers maintain the same isSearching bool
4. searchBar alpha and userInteraction is changed on editControllerDidSelectMultipleItem and editControllerDidDeSelectMultipleItem

resolved all threads

added 1 commit

• 1071e07a - Deletion while editing: Simply dataset logic in EditController

Compare with previous version

changed milestone to %3.5.0

added 3 commits

• ccdaad61 - Minor type in reloadData() in MediaCategoryViewController
• bfcdae36 - MediaCategoryViewController: check model data or search data to determine if empty.
• df5a748c - Search bar: Prevent searchbar from hiding during editing.

Compare with previous version

Fixed some UI bugs! The search bar no longer covers the content. However, it still behaves erratically when isEditing and isSearching are both true together.

When search bar is visible on screen and user starts editing: search bar is sticky to the top of the screen. this is unintended behaviour when the search bar is empty. should only stick to the top if user is actually searching.

When search bar is not visible on screen and user starts editing: no search bar available on screen. User wonders why they can't search and select items.

So far unable to understand how the searchbar being on screen changes the behaviour in the edit screen

resolved all threads

added 1 commit

• 05ae45ce - Search While Editing: scrollViewDidScroll behaviour in editController mirrors...

Compare with previous version

marked this merge request as ready

I think all the UI bugs related to the search bar are fixed now.

added MediaLibrary label

added 1 commit

• 8d011dfc - Edit Controller: call delegate's scrollDidView method

Compare with previous version

Have you tried the actual delete action while searching?

From what I tested the delete action is performed correctly but it doesn't update the view so you still see the deleted items.

I have made two screen recordings to show the behavior:

Screen recordings

Delete_in_search

Delete_in_search_-_2

The rename action seems to have the expected behavior but I have not tested the other actions of the Edit Controller

resolved all threads

added 1 commit

• cba54e60 - Edit Controller: call delegate's scrollDidView method

Compare with previous version

added 2 commits

• aa11b35f - MediaCategoryViewController: Abstract the data-set to a computed variable that...
• 5ae1bdaa - Deletion in search: remove deleted files from search data set post-deletion.

Compare with previous version

added 1 commit

• 82256037 - Media Category View Controller: disable search-bar if any item is selected

Compare with previous version

resolved all threads