Skip to content
Snippets Groups Projects

Player: Add minimizing gesture recognizer

All threads resolved!

This merge request adds:

  • A minimizing gesture recognizer to the media navigation bar allowing the user to minimize the player
  • An extension in order to retrieve the display's corner radius, that is used in the audio player's view.

This merge request also brings an adjustment to the presentation of the players:

  • Both the video and audio players are presented over the current context meaning that when the minimizing gesture will be performed, the user will be able to see the parent view controller instead of a black screen.
  • The mini player is also dismissed when the player enters the fullscreen mode in order to make the animation smoother.

Minimize_-_audio Minimize_-_video

Merge request reports

Merge request pipeline #342111 passed

Merge request pipeline passed for c6ec6849

Approval is optional

Merged by Felix Paul KühneFelix Paul Kühne 1 year ago (May 12, 2023 4:22pm UTC)

Merge details

  • Changes merged into master with c6ec6849.
  • Deleted the source branch.

Pipeline #342116 passed

Pipeline passed for c6ec6849 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • One nit-pick, besides that looks very good to me.

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • added 10 commits

    • 425e7d56...d2e7735d - 4 commits from branch videolan:master
    • 75b25067 - AudioPlayerViewController: Refactor the main view setup
    • f148a343 - Cosmetics: AudioPlayerView: Add additional padding
    • 55bdd720 - PlayerViewController: Add minimizing gesture recognizer
    • 36f627d2 - VideoPlayerViewController: Add minimizing gesture recognizer
    • 24b5c040 - VLCPlayerDisplayController: Present over context + dismiss mini player when needed
    • 68b48886 - UIScreen+DisplayCornerRadius: Add extension to retrieve the display's corner radius

    Compare with previous version

  • Felix Paul Kühne added 11 commits

    added 11 commits

    • 68b48886...c1fd7607 - 5 commits from branch videolan:master
    • ff441c83 - AudioPlayerViewController: Refactor the main view setup
    • 0d794827 - Cosmetics: AudioPlayerView: Add additional padding
    • fcf33f4e - PlayerViewController: Add minimizing gesture recognizer
    • ac54c044 - VideoPlayerViewController: Add minimizing gesture recognizer
    • 0ff39443 - VLCPlayerDisplayController: Present over context + dismiss mini player when needed
    • c6ec6849 - UIScreen+DisplayCornerRadius: Add extension to retrieve the display's corner radius

    Compare with previous version

  • Felix Paul Kühne enabled an automatic merge when the pipeline for c6ec6849 succeeds

    enabled an automatic merge when the pipeline for c6ec6849 succeeds

  • Please register or sign in to reply
    Loading