Craig Reyenga authored 4 months ago and Felix Paul Kühne committed 3 months ago

Each settings item is now of a designated type; the cell simply displays each item as presented without any special logic for each. This new pattern also allows for the removal of all logic that relied on a given settings item's position for its behavior. Now, settings items can be added or removed at will, without affecting the others.

There should be no user-facing changes in this branch; if there are any, they are regressions.

Andrew Breckenridge authored 3 months ago and Felix Paul Kühne committed 3 months ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

Andrew Breckenridge authored 3 months ago and Felix Paul Kühne committed 3 months ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

VideoLAN authored 4 months ago and Felix Paul Kühne committed 3 months ago

Signed-off-by: Felix Paul Kühne <felix@feepk.net>

The VideoPlayerViewController class now inherits from PlayerViewController
just like the AudioPlayerViewController class.

This adds a level of abstraction, reducing the amount of code that is
duplicated between these classes.

Felix Paul Kühne authored 3 months ago and Diogo Simao Marques committed 3 months ago

Fixes prominent crash in the last alpha build

The coding style has been reviewed and fixed, useless methods have
been removed and marks have been added in order to turn the file
more readable.

The passcode is now properly set and is also properly matched with its
length when the biometrics are not enabled.

The appearance of the navigation bar is properly set depending on
the collection view's scroll position.

Appending a media to the queue or removing one from it can now impact
the display of the player controls.

If the play queue contains a single media after such an action, the
player controls will display the seek buttons, if not the skip buttons
will be displayed allowing the user to select different medias from
the queue.

Seek buttons were added to the player controls of the Audio Player
interface in order to easily access these features without the gestures.

Appending a media to the queue or removing one from it can now impact
the display of the player controls.

If the play queue contains a single media after such an action, the
player controls will display the seek buttons, if not the skip buttons
will be displayed allowing the user to select different medias from
the queue.

The seek buttons are now displayed when the media list contains only
a single media.

Pressing the buttons will now display the same information on the screen
with the status label as the seek gestures.

Diogo Simao Marques authored 5 months ago and Felix Paul Kühne committed 5 months ago

The player now switches to the proper one depending on the media
type when the playback moves on to the next media.

If the mini player is displayed, it remains even if the media type
switches.

The media preview is now properly displayed in the mini player with
a clear background.

The updateAudioInterface calls were being made too many times, including
during the phase of preparation of the playback leading to applying
constraints of the videoOutputView on views that were not properly
instanciated yet.

It was causing some glitches on the interface.

Christian Bilodeau-Calame authored 6 months ago and Diogo Simao Marques committed 6 months ago

Issue #1865

EshanSingh-ES authored 7 months ago and Felix Paul Kühne committed 6 months ago

Clouds: Cosmetic Changes

The hack is no longer needed as we switched to libvlc 4.0.

Closes #1818

This helper retrieves the VLCTime object and avoids having to recreate
it based on the mediaDuration int value.

Diogo Simao Marques authored 7 months ago and Felix Paul Kühne committed 6 months ago

The UITableView class already inherits from the UIScrollView one.

Diogo Simao Marques authored 7 months ago and Felix Paul Kühne committed 6 months ago

The VLCFavoriteListViewController files now drop the "VLC" prefix
to conform to the Swift standards.

The proper changes in other files according to this rename have also
been made.