Skip to content

Position reported by Android Auto does not update correctly if previous() is invoked to replay song

Robert Stone requested to merge rhstone/vlc-android:issue-1499-fix-previous-song-progress-indicator into 3.3.x

Description

Invoke the previous() method in the same manner as the next() method. This does a bit more setup in libvlc than seeking, as it completely re-loads the song; however, it does call all the required functions when starting the song over.

Motivation and Context

I was driving my kids to school and received a request from the back seat to start a song over (again). The request was quickly followed by a complaint from my eagle eyed back-seat drivers that the "orange thing" (progress indicator) did not start over on the head-unit. I didn't believe it at first, but we investigated a bit more, and confirmed this was the first software bug in VLC discovered by my son.

How Has This Been Tested?

Load a large playlist, and advance next/jump to previous over and over. Wait until song is mid-way through and press previous. Observe progress indicator is reset to 0.

Confirmed navigation to a previous song in the playlist within the first 5 seconds works correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING section of the README document.

Resolves

Fixes: #1499 (closed)

Edited by Robert Stone

Merge request reports

VideoLAN code repository instance