Hide PiP on more unsupported devices

Fixes #3199 (closed)

changed milestone to %3.6.x

requested review from @Skantes

This works though I don't think that's the way to fix this.

in primary && AndroidDevices.pipAllowed && !AndroidDevices.isDex(activity) && activity.packageManager.hasSystemFeature(PackageManager.FEATURE_PICTURE_IN_PICTURE) the packageManager.hasSystemFeature(PackageManager.FEATURE_PICTURE_IN_PICTURE) is already checked in AndroidDevices.pipAllowed but overriden by isAndroidTv

We in fact already have two hasPip variables in Settings.kt, and AndroidDevices.kt that both will return true for TV.

IMHO this should be cleaned and then to fix this issue, check whatever hasPiP is left.

added 6 commits

• 379ad0fe...1f8dbf77 - 5 commits from branch videolan:master
• b3859780 - Rework the PiP conditions

Compare with previous version

added 1 commit

• aa0f0570 - Rework the PiP conditions

Compare with previous version

added 1 commit

• caebf7e6 - Rework the PiP conditions

Compare with previous version

What about the has PiP and pipAllowed that are in Settings.kt ? There still is a definition similar to the one that was refactored in AndroidDevices.kt.

added 1 commit

• a59d4526 - Remove useless PiP conditions in Settings

Compare with previous version

resolved all threads

enabled an automatic merge when all merge checks for a59d4526 pass

merged