Skip to content
Snippets Groups Projects

Breadcrumb UI fixes

Merged Breadcrumb UI fixes
(removed):master into master
Merged rahul-gill requested to merge (removed):master into master
  1. fixed [#2206 (closed) ]: breadcrumb navigation fix
  2. when chosing subtitle file, navigating to parent directories makes the breadcrumb invisible

Merge request reports

Checking pipeline status.

Approval is optional

Merged by avatar (May 13, 2025 2:34am UTC)

Merge details

Pipeline #148213 passed

Stage:

    Pipeline passed for 6d5e5d63 on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • Nicolas Pomepuy
      Nicolas Pomepuy @Aza ·
      Maintainer

      Thanks a lot for this contribution. i will review it ASAP.

      1. when chosing subtitle file, navigating to parent directories makes the breadcrumb invisible

      What do you mean by that? Is that a new issue you spotted? Does this MR solve it?

      Edited by Nicolas Pomepuy
    • rahul-gill
      rahul-gill @rahul-gill ·
      Author Contributor

      Yeah. In the FilePickerFragment.kt, when choosing a local subtitles file for a video, if we navigate to any other directory, the breadcrumb disappears. Navigating to other directory built a new breadcrumb with null layout manager and adapter.

    • Nicolas Pomepuy
      Nicolas Pomepuy @Aza ·
      Maintainer

      LGTM. Thanks for your contribution!

    • Nicolas Pomepuy merged

      merged

    Please register or sign in to reply

    VideoLAN code repository instance