MlInit: skipping permissions on onboarding, causes discovery fails
Description
Not giving permissions during onboarding or skipping it will cause the medialibrary init to fail with discovery failing. This requires a device that also has external storage sd card.
Steps to reproduce
- Clean install
- Skip onboarding
- Select internal storage in medialibrary folders
Context
App version
Master
Android version
10
App mode
Smartphone
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Duncan McNamara changed milestone to %3.5.x
changed milestone to %3.5.x
- Duncan McNamara added Media Indexing & Backend label
added Media Indexing & Backend label
- Duncan McNamara assigned to @Skantes
assigned to @Skantes
- Duncan McNamara changed the description
changed the description
- Duncan McNamara mentioned in merge request !1545 (merged)
mentioned in merge request !1545 (merged)
- Maintainer
I am not sure I understood the reproduction steps, but either the fix is not good or I found another one.
Logs:
2022-09-21 07:57:33.189 11890-11937/org.videolan.vlc.debug I/VLC/medialibrary: [T#-917282256] ../src/discoverer/DiscovererWorker.cpp:110 discover Adding file:///storage/emulated/0/Music/ to the folder discovery list 2022-09-21 07:57:33.189 11890-11937/org.videolan.vlc.debug I/VLC/medialibrary: [T#-917282256] ../src/discoverer/DiscovererWorker.cpp:394 enqueue Queuing entrypoint file:///storage/emulated/0/Music/ of type AddEntryPoint 2022-09-21 07:57:33.189 11890-11937/org.videolan.vlc.debug I/VLC/medialibrary: [T#-917282256] ../src/discoverer/DiscovererWorker.cpp:394 enqueue Queuing entrypoint file:///storage/emulated/0/Music/ of type Reload 2022-09-21 07:57:33.190 11890-12971/org.videolan.vlc.debug I/VLC/medialibrary: [T#-1070501328] ../src/discoverer/DiscovererWorker.cpp:419 run Entering DiscovererWorker thread 2022-09-21 07:57:33.190 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/MediaLibrary.cpp:2215 onDiscovererIdleChanged Discover thread was resumed 2022-09-21 07:57:33.191 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/MediaLibrary.cpp:2202 onBackgroundTasksIdleChanged Setting background idle state to false 2022-09-21 07:57:33.196 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/discoverer/DiscovererWorker.cpp:481 run Running task of type AddEntryPoint 2022-09-21 07:57:33.273 11890-12762/org.videolan.vlc.debug D/VLC: [e286afa0/31da] libvlc services discovery: Adding server 'Plex Media Server: AzaNas' with uuid 'uuid:131c056f-c006-f68c-2e98-a4ef338f207f' 2022-09-21 07:57:33.478 11890-12763/org.videolan.vlc.debug W/VLC: [e286afa0/31db] libvlc services discovery: Server with uuid 'uuid:131c056f-c006-f68c-2e98-a4ef338f207f' already exists. 2022-09-21 07:57:34.118 11890-11890/org.videolan.vlc.debug W/ActivityThread: handleWindowVisibility: no activity for token android.os.BinderProxy@11aa0a5 2022-09-21 07:57:34.177 11890-11890/org.videolan.vlc.debug I/AppCompatViewInflater: app:theme is now deprecated. Please move to using android:theme instead. 2022-09-21 07:57:34.183 11890-11890/org.videolan.vlc.debug W/TabLayout: MODE_SCROLLABLE + GRAVITY_FILL is not supported, GRAVITY_START will be used instead 2022-09-21 07:57:34.214 11890-11890/org.videolan.vlc.debug W/SingleEvent: Multiple observers registered but only one will be notified of changes. 2022-09-21 07:57:34.263 11890-11940/org.videolan.vlc.debug D/EGL_emulation: eglMakeCurrent: 0xe281a480: ver 3 0 (tinfo 0xe280f6f0) 2022-09-21 07:57:34.317 11890-11940/org.videolan.vlc.debug D/EGL_emulation: eglMakeCurrent: 0xe281a480: ver 3 0 (tinfo 0xe280f6f0) 2022-09-21 07:57:34.324 11890-11938/org.videolan.vlc.debug D/VLC: [e286c4a0/2ea2] libvlc services discovery: removing module "dsm" 2022-09-21 07:57:34.324 11890-11938/org.videolan.vlc.debug D/VLC: [e286afa0/2ea2] libvlc services discovery: removing module "upnp" 2022-09-21 07:57:34.334 11890-11938/org.videolan.vlc.debug D/VLC: [e286c510/2ea2] libvlc services discovery: removing module "microdns" 2022-09-21 07:57:38.198 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/discoverer/DiscovererWorker.cpp:481 run Running task of type Reload 2022-09-21 07:57:38.198 11890-12971/org.videolan.vlc.debug I/VLC/medialibrary: [T#-1070501328] ../src/discoverer/DiscovererWorker.cpp:536 runReload Reloading folder file:///storage/emulated/0/Music/ 2022-09-21 07:57:38.198 11890-12971/org.videolan.vlc.debug W/VLC/medialibrary: [T#-1070501328] ../src/Folder.cpp:525 fromMrl Failed to get device containing an existing folder: file:///storage/emulated/0/Music/ 2022-09-21 07:57:38.199 11890-12971/org.videolan.vlc.debug E/VLC/medialibrary: [T#-1070501328] ../src/discoverer/FsDiscoverer.cpp:239 reload Can't reload file:///storage/emulated/0/Music/: folder wasn't found in database 2022-09-21 07:57:38.199 11890-12971/org.videolan.vlc.debug E/VLC/MediaParsingService: onDiscoveryFailed 2022-09-21 07:57:38.200 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/MediaLibrary.cpp:2215 onDiscovererIdleChanged Discoverer thread went idle 2022-09-21 07:57:38.200 11890-12971/org.videolan.vlc.debug D/VLC/medialibrary: [T#-1070501328] ../src/MediaLibrary.cpp:2202 onBackgroundTasksIdleChanged Setting background idle state to true
- Duncan McNamara closed with commit 2338bd92
closed with commit 2338bd92
- Nicolas Pomepuy closed with merge request !1545 (merged)
closed with merge request !1545 (merged)
- Duncan McNamara mentioned in commit d24955bd
mentioned in commit d24955bd
- Duncan McNamara mentioned in commit fdf003bb
mentioned in commit fdf003bb
Please register or sign in to reply