Before that we used the audio only query that filtered out the items that
only contains streams. This commit changes the query to all and then filter
all the playlist containing only video media

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

The Medialibrary sometimes doesn't have the media's length,
and won't know that the file has ended.

For some files this causes a finished video to keep it's time and when
played again starts at the end, and leave the player.

This forces the ML to mark the file as finished and reset it's time

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Instead of re-adding the default internal storage as an ML root, save
previous roots, reset the db, and re-add these roots.

This is !2080 but for TV as I forgot to also apply the changes to the tv
settings

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Some filenames from opensubtitles.org had characters not authorized for an
Android Uri. This sanitizes the filename so it can be used as dest in copyFile
Cf https://www.rfc-editor.org/rfc/rfc2396 #2.4.3 mentionned in the Uri.parse
method doc

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

If for some reason the FileUtils.copyFile fails, the subtitleItem should
be removed from the ExternalSubDirectory's downloading items to change
the item's state back to NotDownloaded to stop the download progress
animation. Also nice to display a snackbar error for the user.

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3142

Duncan McNamara authored 3 months ago and Nicolas Pomepuy committed 2 months ago

In all the PlaylistManager "save" methods, incognito mode wasn't
checked.

Fixes #3125

Duncan McNamara authored 3 months ago and Nicolas Pomepuy committed 2 months ago

Instead of re-adding the default internal storage as an ML root, save
previous roots, reset the db, and re-add these roots.

Fixes #3122

Duncan McNamara authored 3 months ago and Nicolas Pomepuy committed 2 months ago

Files shared through file providers can be played natively using file
descriptors, meaning that they can be opened even though the VLC for
Android doesn't have any file access permissions given be the user.

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

In the case of the VideoGridFragment, canReadVideos will always return
true below API 33, showing media if there were media indexed before
revoking file permissions.

On android 11 an 12 (API 30/31/32) when media permission only,
isExternalStorageManager will return false, but checking for
READ_EXTERNAL_STORAGE will return true.

On Android API 33+, if given only audio or video permission,
READ_EXTERNAL_STORAGE will also return true meaning that the check must
be restrained to API 30/31/32,

Furthermore, for API 30/31/32, isExternalStorageManager also needs to be
checked for when the app has full access.

Fixes #3129

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3135

Except when the video is played as audio / in background

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3138

Compact mode is used when the empty view only displays an image and a text

Fixes #3141