Duncan McNamara authored 3 months ago and Nicolas Pomepuy committed 2 months ago

Files shared through file providers can be played natively using file
descriptors, meaning that they can be opened even though the VLC for
Android doesn't have any file access permissions given be the user.

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

In the case of the VideoGridFragment, canReadVideos will always return
true below API 33, showing media if there were media indexed before
revoking file permissions.

On android 11 an 12 (API 30/31/32) when media permission only,
isExternalStorageManager will return false, but checking for
READ_EXTERNAL_STORAGE will return true.

On Android API 33+, if given only audio or video permission,
READ_EXTERNAL_STORAGE will also return true meaning that the check must
be restrained to API 30/31/32,

Furthermore, for API 30/31/32, isExternalStorageManager also needs to be
checked for when the app has full access.

Fixes #3129

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3135

Except when the video is played as audio / in background

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3138

Compact mode is used when the empty view only displays an image and a text

Fixes #3141

This reverts commit 4702f695.

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

On a new install, the manageMediaPermsCheck onclicklistener will
ask for video/audio permission for API 33+, but for 30+ goes to
getStoragePermission which ends calling requestStorageAccess.
When API 30+ this will spawn a new PermissionListDialog, creating a
loop.

In the onClickListener, asking for READ_EXTERNAL_STORAGE straight away
for API 30+ solves this.

Fixes #3137

Fixes #3132

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Revert of c49382e3. After some discussions, and user
complaints it was decided to go back to the old behavior and keep repeat
one enable when pressing next.

Most players do that. VLC for iOS also changed to this behavior

Fixes #3131

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3095

Because fast seek is not precise, it will usually seek before the
requested time when seeking with abrepeat, causing the abrepeat to seek
again, and stucks the player in a loop.
Adding a small margin of time in which the seek is considered acceptable
when fast seek is enabled stops it from looping.

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Apparently I still don't know that the project is called VLC for Android
and not vlc-android ...

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

Because of all the different permission APIs, it is easier to create a
File where we want to extract the subtitle file, and check if we have
write permission.

Fixes #3133

Nicolas Pomepuy authored 2 months ago and Duncan McNamara committed 2 months ago

Fixes #3130

Nicolas Pomepuy authored 3 months ago and Duncan McNamara committed 2 months ago

Fixes #3011

Nicolas Pomepuy authored 3 months ago and Duncan McNamara committed 2 months ago

Fixes #3124

Nicolas Pomepuy authored 3 months ago and Duncan McNamara committed 2 months ago

Fixes #3121

Duncan McNamara authored 2 months ago and Nicolas Pomepuy committed 2 months ago

This reverts commit 8880ccca.

Reverts the MR !1720
This MR was not finished, and made unecessary additions, causing
playqueues of one file to play twice sometimes. I should not have merged
it ...

Fixes #3116