When path was changed from char[] to char*, a free was added to
dvdnav_free_dup, but the string was not copied in dvdnav_dup resulting
in a double free.

Marcel Mol authored 10 years ago and Jean-Baptiste Kempf committed 10 years ago

Some DVDs seem to use command type 7 for something.
But it will hit the 'Unknown command' check, resulting in asser(0).
I.e. DVD refuses to play.

By removing the assert() call the DVD seems to play fine.
This patch removes the assert and corrects the error message
(it is a 'command type', not a 'command')

Signed-off-by: Marcel Mol <marcel@mesa.nl>
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

If vm_jump_cell_block failed, we should return fail to
dvdnav_jump_to_sector_by_time() call

Also add explicit path to ignored generated files.

And fail in new error cases

Fixes builds for Hurd...

Dominik Mierzejewski authored 10 years ago and Jean-Baptiste Kempf committed 10 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

KO Myung-Hun authored 10 years ago and Jean-Baptiste Kempf committed 10 years ago

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Thorsten Wilmer authored 10 years ago and Jean-Baptiste Kempf committed 10 years ago

this is a keyword in C++, therefore ... dvdnav/dvdnav.h:93:43: error: expected ‘,’ or ‘...’ before ‘this’

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

beandog authored 11 years ago and Jean-Baptiste Kempf committed 11 years ago

Fixes compiler warning:

src/vm/vm.c:183:17: warning: equality comparison with extraneous
parentheses [-Wparentheses-equality]
    if((data[i] == 0)) break;
        ~~~~~~~~^~~~

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Failing is a correct behavior, here...

LP: #370884

LP: #487414