Skip to content
Snippets Groups Projects

Update libvlc hash to include opengl swizzle revert

Closed Soomin Lee requested to merge bubu/VLCKit:bump/ogl/swizzle/01 into 3.0
1 unresolved thread

This removes the patches added for the quick fix release.

Indeed, with the merge of vlc!1693 (merged), the patches aren't needed anymore.

Edited by Soomin Lee

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
25 25 ROOT_DIR=empty
26 26 FARCH="all"
27 27
28 TESTEDHASH="a695dc03" # libvlc hash that this version of VLCKit is build on
28 TESTEDHASH="270330c90d" # libvlc hash that this version of VLCKit is build on
  • Please trim to 8 digits. Thank you.

  • Author Maintainer

    Is there a reason we are enforcing 8 ? This length of abbreviation was automatically generated by git.

    Since git 2.11, the generated abbreviated SHA-1 minimum length scales with the number of the objects in the repository.

    2.11 release note.

    If we want to enforce the abbreviation to 8 we could consider adding it to the README to configure core.abbrev to 8 but I don't see a real reason why we should go against that.

    Let me know if I missed something.

  • This should work, but I'm not sure if the packaging script will handle that correctly. That is my only fear. Needs testing.

  • Please register or sign in to reply
  • Closing this MR as it was superseded by !158 (closed)

  • Please register or sign in to reply
    Loading