Parse URLs like "http://[fe80::1%25eth0]" (ref. RFC 6874).

Maxime Chapelet authored 3 months ago and Felix Paul Kühne committed 3 months ago

libvlc client can set a block that will be called each time picture in picture is
started or closed.

`VLCPictureInPictureWindowControlling` implementation is also moved from the display
module to the picture in picture module

Fatih Uzunoğlu authored 3 months ago and Steve Lhomme committed 3 months ago

I don't see a reason why `qt-backdrop-blur` should not be
respected for intra-window backdrop blur effect (Frosted
Glass Effect).

The said setting was first added to disable inter-window
backdrop blur, which is currently supported with the
following circumstances:

- KWin (Wayland and X11) and KWindowSystem is available.
- Windows 11 22H2 (native acrylic effect
  `DWMSBT_TRANSIENTWINDOW`).
- Windows 10/11 simulated acrylic effect (`compositor_
  dcomp_acrylicsurface.cpp`) when Direct Composition is
  used (`--qt-compositor=dcomp`).

We also have our own backdrop blur effect, currently
used for the mini player and the indexing progress
indicator.

I propose that if the user explicitly opt-outs from
backdrop blur by unsetting `qt-backdrop-blur` (it is
set by default), the application shall respect that
for intra-window backdrop blur effect.

Fatih Uzunoğlu authored 3 months ago and Steve Lhomme committed 3 months ago

`CompositorWayland::onSurfaceSizeChanged()` already adjusts
the size.

Fatih Uzunoğlu authored 3 months ago and Steve Lhomme committed 3 months ago

- This fixes the window flashing white when opened, which is really annoying when
the interface is dark.
- This fixes the white background getting exposed until the scene covers the new
area when the window is resized.
- This increases performance due to not having to copy buffers (within GPU, or inter
GPU-CPU unlike WS_EX_LAYERED).
- This makes it possible to use the native acrylic backdrop effect that Windows 11
22H2 provides.

Fatih Uzunoğlu authored 3 months ago and Steve Lhomme committed 3 months ago

Without this scrolling does not yield towards the favored direction.

Claudio Cambra authored 3 months ago and Felix Paul Kühne committed 3 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 3 months ago and Felix Paul Kühne committed 3 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Pierre Lamot authored 3 months ago and Steve Lhomme committed 3 months ago

This avoids the menubar overlapping the CSD or being inaccessible when the
space is scarce

Prince Gupta authored 4 months ago and Steve Lhomme committed 3 months ago

use default delegates

The prefered addAction signature has changed [^1] in 6.3 [^2].
We can just set it separately once the action is created.
It also makes it easier to find shortcuts we set.

[^1] https://doc.qt.io/qt-6/qmenu-obsolete.html#addAction-4
[^2] https://doc.qt.io/qt-6.5/qwidget.html#addAction-9

It's defined as a struct.

See https://doc.qt.io/qt-6/qvariant-obsolete.html#Type-enum

See https://doc.qt.io/qt-6/qcheckbox.html#stateChanged

Apparently since it was introduced in 2408b38a

Other variants of the same function are used in the file.

Fixes #28918

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Pierre Lamot authored 3 months ago and Felix Paul Kühne committed 3 months ago

We need to explicitly disconnect signals here:

- destructor will release m_sourcesProvider

- the shared MediaSourceModel will be released

- they will notify mediaRemoved, but the slot expects the shared
  MediaSourceModel to be valid

At this point we don't care about model updates

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 3 months ago

Viewporter protocol is used for fractional scaling, and currently we do
not use the fractional scaling protocol ourselves because Qt uses it and
provides scale through the interface window.

However, Qt starts supporting fractional scale on Wayland starting with
6.5.0. If Qt version is lower than 6.5.0, it is not necessary to use the
viewporter protocol because Qt is not going to provide the fractional
scale anyway.

I don't think it is a good idea to start using the fractional protocol
ourselves to get the fractional scale, instead of Qt providing that. The
reason is the video window should use the same scale as the interface
window for video integration, and it complicates the code unnecessarily.

I have not realized this before, because I test Qt code with Qt 6.2 and
Qt 6.8, and I can not test Wayland changes on Qt 6.2 because it has never
been working for me on Wayland.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 3 months ago

As otherwise we load placeholder image just before the artwork url
becomes available, this does not look good because often time the
item gets preparsed quickly.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 3 months ago

This is really not necessary.

Fatih Uzunoğlu authored 3 months ago and Felix Paul Kühne committed 3 months ago

Otherwise the states (fullscreen for now) is not saved.